Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
Fix exception on import in MacOS#763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is related to my fix ingitpython-developers#658. Apparently, MacOS adds a gitexecutable that is just a stub which displays an error. This gets pastthe try/except I added ingitpython-developers#658, and allows all of the GitPythoncomponents to be imported, but since the executable is not *actually*git, it results in an exception when ``refresh()`` attemepts to run a``git version``.
This was referencedJun 1, 2018
Please apologize the late merge, and thanks a lot for this improvement! It's much appreciated! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to my fix in#658. Apparently, MacOS adds a git executable that is just a stub which displays an error. This gets past the try/except I added in#658, and allows all of the GitPython components to be imported, but since the executable is notactually git, it results in an exception when
refresh()attemepts to run agit version.Fixes#762.