Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork940
Allow mmap not just for py2.6, 2.7 and 3.6+ but also 3.0+#736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+1 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecov-io commentedMar 18, 2018
Codecov Report
@@ Coverage Diff @@## master #736 +/- ##==========================================- Coverage 94.66% 94.66% -0.01%========================================== Files 60 60 Lines 9340 9338 -2 ==========================================- Hits 8842 8840 -2 Misses 498 498
Continue to review full report at Codecov.
|
What a great catch! Thanks a lot for your contribution! |
riley-martine pushed a commit to riley-martine/GitPython that referenced this pull requestDec 7, 2023
…heckAllow mmap not just for py2.6, 2.7 and 3.6+ but also 3.0+
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version check only checks the minor number: the
yin Pythonx.y.So mmap is available for Python 2.6 and 2.7, and 3.6+, but not for 3.0 to 3.5.
But I think the intent was to have memory maps for Python 2.6 and up, including all of Python 3.x (and 4.x etc.).
As Python 2.6 is the minimum supported version, the
allow_mmapis alwaysTruefor supported versions.