Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Allow mmap not just for py2.6, 2.7 and 3.6+ but also 3.0+#736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 1 commit intogitpython-developers:masterfromhugovk:fix-version-check
Mar 18, 2018
Merged

Allow mmap not just for py2.6, 2.7 and 3.6+ but also 3.0+#736

Byron merged 1 commit intogitpython-developers:masterfromhugovk:fix-version-check
Mar 18, 2018

Conversation

hugovk
Copy link
Contributor

This version check only checks the minor number: they in Pythonx.y.

So mmap is available for Python 2.6 and 2.7, and 3.6+, but not for 3.0 to 3.5.

But I think the intent was to have memory maps for Python 2.6 and up, including all of Python 3.x (and 4.x etc.).

As Python 2.6 is the minimum supported version, theallow_mmap is alwaysTrue for supported versions.

@ByronByron merged commit9f12b26 intogitpython-developers:masterMar 18, 2018
@codecov-io
Copy link

Codecov Report

Merging#736 intomaster willdecrease coverage by<.01%.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #736      +/-   ##==========================================- Coverage   94.66%   94.66%   -0.01%==========================================  Files          60       60                Lines        9340     9338       -2     ==========================================- Hits         8842     8840       -2  Misses        498      498
Impacted FilesCoverage Δ
git/index/base.py94.64% <100%> (-0.03%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update190c045...693b171. Read thecomment docs.

@Byron
Copy link
Member

What a great catch! Thanks a lot for your contribution!

hugovk reacted with thumbs up emoji

@hugovkhugovk deleted the fix-version-check branchMarch 18, 2018 20:42
@ByronByron added this to thev2.1.9 - Bugfixes milestoneMar 24, 2018
riley-martine pushed a commit to riley-martine/GitPython that referenced this pull requestDec 7, 2023
…heckAllow mmap not just for py2.6, 2.7 and 3.6+ but also 3.0+
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
@hugovk@codecov-io@Byron
[8]ページ先頭
©2009-2025 Movatter.jp