Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

BF: process included files before the rest#700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 21 commits intogitpython-developers:masterfromyarikoptic:bf-includes
Dec 11, 2017

Conversation

yarikoptic
Copy link
Contributor

Alternative solution to#628 - may be I have missed why it was more complex than 1 line change? ;)

It also includes disabled (well -- raises SkipTest) for the fact that in current logic processing of included files is done not right at the point of inclusion. That makes it behave differently from stock git config

@codecov-io
Copy link

codecov-io commentedNov 28, 2017•
edited
Loading

Codecov Report

Merging#700 intomaster willincrease coverage by1.82%.
The diff coverage is93.24%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #700      +/-   ##==========================================+ Coverage   92.83%   94.65%   +1.82%==========================================  Files          61       60       -1       Lines       10152     9344     -808     ==========================================- Hits         9425     8845     -580+ Misses        727      499     -228
Impacted FilesCoverage Δ
git/test/test_submodule.py99.23% <ø> (+1.71%)⬆️
git/refs/log.py93.84% <0%> (ø)⬆️
git/repo/base.py95.96% <0%> (+0.67%)⬆️
git/config.py92.76% <100%> (+0.32%)⬆️
git/test/test_util.py98.52% <100%> (+10.29%)⬆️
git/diff.py99.11% <100%> (ø)⬆️
git/exc.py96.42% <100%> (ø)⬆️
git/test/test_config.py98.33% <100%> (+0.08%)⬆️
git/compat.py65.03% <100%> (+0.21%)⬆️
git/test/test_commit.py100% <100%> (ø)⬆️
... and22 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea2cd130...0a6cb4a. Read thecomment docs.

I did keep some "bare" except with catch all Exception: , while tried to disableflake8 complaints where clearly all exceptions are to be catched
@yarikoptic
Copy link
ContributorAuthor

I guess I will wait for#702 to be merged first so we could get travis pass here as well

@ByronByron merged commit03126bf intogitpython-developers:masterDec 11, 2017
@Byron
Copy link
Member

@yarikoptic As always, thanks so much for chiming in :)! I merged the referenced 'make travis happy' branch in, and it seems to work just fine.

@yarikopticyarikoptic deleted the bf-includes branchDecember 15, 2017 21:45
riley-martine pushed a commit to riley-martine/GitPython that referenced this pull requestDec 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@yarikoptic@codecov-io@Byron
[8]ページ先頭
©2009-2025 Movatter.jp