Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork966
BF: process included files before the rest#700
Merged
Byron merged 21 commits intogitpython-developers:masterfromDec 11, 2017
Merged
BF: process included files before the rest#700Byron merged 21 commits intogitpython-developers:masterfrom
Byron merged 21 commits intogitpython-developers:masterfrom
Conversation
Merged 2.1.7 into master (just VERSION changes)
codecov-io commentedNov 28, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #700 +/- ##==========================================+ Coverage 92.83% 94.65% +1.82%========================================== Files 61 60 -1 Lines 10152 9344 -808 ==========================================- Hits 9425 8845 -580+ Misses 727 499 -228
Continue to review full report at Codecov.
|
I did keep some "bare" except with catch all Exception: , while tried to disableflake8 complaints where clearly all exceptions are to be catched
ContributorAuthor
yarikoptic commentedNov 28, 2017
I guess I will wait for#702 to be merged first so we could get travis pass here as well |
…travisBF (codename "happy travis"): trying to address lints etc to make Travis green again
…into yarikoptic-bf-includes
Member
Byron commentedDec 11, 2017
@yarikoptic As always, thanks so much for chiming in :)! I merged the referenced 'make travis happy' branch in, and it seems to work just fine. |
riley-martine pushed a commit to riley-martine/GitPython that referenced this pull requestDec 7, 2023
BF: process included files before the rest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative solution to#628 - may be I have missed why it was more complex than 1 line change? ;)
SkipTest, andskipIfIt also includes disabled (well -- raises SkipTest) for the fact that in current logic processing of included files is done not right at the point of inclusion. That makes it behave differently from stock git config