Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork960
Only gc.collect() under windows#686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Under Windows, tempfile objects are holding references to open filesuntil the garbage collector closes them and frees them. Explicitcalls to gc.collect() were added to the finalizer for the Repo classto force them to be closed synchronously. However, this is expensive,especially in large, long-running programs. As a temporary measureto alleviate the performance regression on other platforms, onlyperform these calls when running under Windows.Fixesgitpython-developers#553
openstack-gerrit pushed a commit to openstack-infra/zuul that referenced this pull requestOct 10, 2017
Timeout remote git operations after 300 seconds.Because it could be in an invalid state, delete the local repo if atimeout occurs (subsequent operations will recreate it).This replaces our use of the clone_from() and fetch() methods fromGitPython with lower-level equivalents. The high-level methodsdo not currently permit the hard timeout.The GitPython requirement is changed to a temporary fork until bothgitpython-developers/GitPython#682andgitpython-developers/GitPython#686end up in a release.Change-Id: I7f680472a8d67ff2dbe7956a8585fb3714119e65
Member
Byron commentedNov 2, 2017
Thanks a lot for this fix! |
riley-martine pushed a commit to riley-martine/GitPython that referenced this pull requestDec 7, 2023
Only gc.collect() under windows
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Under Windows, tempfile objects are holding references to open files
until the garbage collector closes them and frees them. Explicit
calls to gc.collect() were added to the finalizer for the Repo class
to force them to be closed synchronously. However, this is expensive,
especially in large, long-running programs. As a temporary measure
to alleviate the performance regression on other platforms, only
perform these calls when running under Windows.
Fixes#605