Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork941
Fix encoding issue with stderr_value and kill_after_timeout#682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
We don't properly encode our error message under python3.Signed-off-by: Paul Belanger <pabelanger@redhat.com>
codecov-io commentedOct 5, 2017
Codecov Report
@@ Coverage Diff @@## master #682 +/- ##======================================= Coverage 92.95% 92.95% ======================================= Files 61 61 Lines 10065 10065 ======================================= Hits 9356 9356 Misses 709 709
Continue to review full report at Codecov.
|
Thanks a lot for your contribution! |
Timeout remote git operations after 300 seconds.Because it could be in an invalid state, delete the local repo if atimeout occurs (subsequent operations will recreate it).This replaces our use of the clone_from() and fetch() methods fromGitPython with lower-level equivalents. The high-level methodsdo not currently permit the hard timeout.The GitPython requirement is changed to a temporary fork until bothgitpython-developers/GitPython#682andgitpython-developers/GitPython#686end up in a release.Change-Id: I7f680472a8d67ff2dbe7956a8585fb3714119e65
…dingFix encoding issue with stderr_value and kill_after_timeout
We don't properly encode our error message under python3.
Signed-off-by: Paul Belangerpabelanger@redhat.com