Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Store submodule name#679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jakirkham
Copy link
Contributor

Fixes#678

Seems there are a plethora of things that expect to be able to get a submodule's name. However it is not defined ifSubmodule.add finds the submodule already exists. This is one attempt at trying to solve this issue.

@Byron
Copy link
Member

Thanks for your contribution! At this time I unfortunately also don’t know if there are better ways to fix this, but believe it’s OK to assume it’s not making anything worse if the tests are not breaking.
Ideally there would also be a test that requires the code-change in order to be passing, but I understand the test-suite is messy and impossible to understand, so I wouldn’t ask for it :)!

@ByronByron merged commit95ff827 intogitpython-developers:masterOct 2, 2017
@jakirkhamjakirkham deleted the fix_create_submodule branchOctober 2, 2017 15:07
@jakirkham
Copy link
ContributorAuthor

At this time I unfortunately also don’t know if there are better ways to fix this, but believe it’s OK to assume it’s not making anything worse if the tests are not breaking.

After trying a few things locally, this seemed to allow the submodule to behave normally. Though would think the name should be coming from.gitmodules. Just wasn't clear to me why that wasn't happening or how to fix it.

Ideally there would also be a test that requires the code-change in order to be passing, but I understand the test-suite is messy and impossible to understand, so I wouldn’t ask for it :)!

Sorry. Should have included a test. TBH wasn't sure if this seemingly hacky fix would be accepted or so quickly. 😄 Thanks for that. I'll give the test some thought.

jakirkham added a commit to jakirkham/conda-forge-webservices that referenced this pull requestOct 2, 2017
Uses a workaround already accepted upstream to fix `create_submodule`when the submodule already exists. In particular naming the submodulewith the user provided name. By being able to use `create_submodule`,this script runs substantially faster than when calling `submodule`.Reason being calling `submodule` lists all submodules in the repo andthen selects the one we named. Whereas `create_submodule` simplyprovides us the requested submodule. So using this workaround isnecessary for the performance improvement it provides.ref:gitpython-developers/GitPython#679
riley-martine pushed a commit to riley-martine/GitPython that referenced this pull requestDec 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jakirkham@Byron

[8]ページ先頭

©2009-2025 Movatter.jp