Sep 21, 2017 · Sep 8, 2017 · Sep 8, 2017
diff --git a/git/objects/submodule/base.py b/git/objects/submodule/base.py
            reader = self.config_reader()
            # default submodule values
            try:
                self.path = reader.get_value('path')
                self.path = reader.get('path')
            except cp.NoSectionError:
                raise ValueError("This submodule instance does not exist anymore in '%s' file"
                                 % osp.join(self.repo.working_tree_dir, '.gitmodules'))
            # end
            self._url = reader.get_value('url')
            self._url = reader.get('url')
            # git-python extension values - optional
            self._branch_path = reader.get_value(self.k_head_option, git.Head.to_full_path(self.k_head_default))
        elif attr == '_name':

        for sms in parser.sections():
            n = sm_name(sms)
            p = parser.get_value(sms, 'path')
            u = parser.get_value(sms, 'url')
            p = parser.get(sms, 'path')
            u = parser.get(sms, 'url')
            b = cls.k_head_default
            if parser.has_option(sms, cls.k_head_option):
                b = str(parser.get_value(sms, cls.k_head_option))
                b = str(parser.get(sms, cls.k_head_option))
            # END handle optional information

            # get the binsha
Original file line number	Diff line number	Diff line change
Expand Up		@@ -123,12 +123,12 @@ def _set_cache_(self, attr):
		reader = self.config_reader()
		# default submodule values
		try:
		self.path = reader.get_value('path')
		self.path = reader.get('path')
		except cp.NoSectionError:
		raise ValueError("This submodule instance does not exist anymore in '%s' file"
		% osp.join(self.repo.working_tree_dir, '.gitmodules'))
		# end
		self._url = reader.get_value('url')
		self._url = reader.get('url')
		# git-python extension values - optional
		self._branch_path = reader.get_value(self.k_head_option, git.Head.to_full_path(self.k_head_default))
		elif attr == '_name':
Expand DownExpand Up		@@ -1168,11 +1168,11 @@ def iter_items(cls, repo, parent_commit='HEAD'):

		for sms in parser.sections():
		n = sm_name(sms)
		p = parser.get_value(sms, 'path')
		u = parser.get_value(sms, 'url')
		p = parser.get(sms, 'path')
		u = parser.get(sms, 'url')
		b = cls.k_head_default
		if parser.has_option(sms, cls.k_head_option):
		b = str(parser.get_value(sms, cls.k_head_option))
		b = str(parser.get(sms, cls.k_head_option))
Copy link ContributorAuthor yarikopticSep 8, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. could even strip away us of str here... note that`get` is still advisable instead of`get_value` since it could cast+str`1.0` to`1` and then`false` to`False`.
		# END handle optional information

		# get the binsha
Expand Down