Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
BF: use get, not casting get_value while dealing with submodule path/url etc#667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ok -- ready to be merged! as#668 experiment showed -- last two runs of appveyor seems to be present also in current master, so have nothing to do with this PR. |
b = cls.k_head_default | ||
if parser.has_option(sms, cls.k_head_option): | ||
b = str(parser.get_value(sms, cls.k_head_option)) | ||
b = str(parser.get(sms, cls.k_head_option)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
could even strip away us of str here... note thatget
is still advisable instead ofget_value
since it could cast+str1.0
to1
and thenfalse
toFalse
.
FWIW our battery of tests pass now, which puts more confidence into this fix, since we do use submodules extensively. quick merge/release would be appreciated meanwhile, if there would be no activity, I will absorb the patch to at least (Neuro)Debian packages |
knock knock@Byron -- this PR seems to be quite an easy fix to digest, merge and it would be very appreciated... some folks might have had submodules like |
codecov-io commentedSep 20, 2017
Codecov Report
@@ Coverage Diff @@## master #667 +/- ##=========================================+ Coverage 92.57% 94.38% +1.8%========================================= Files 61 61 Lines 9968 9969 +1 =========================================+ Hits 9228 9409 +181+ Misses 740 560 -180
Continue to review full report at Codecov.
|
BF: use get, not casting get_value while dealing with submodule path/url etc
hopefullycloses#613
did a quick shot, didn't do any tests besides locally: