Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

detect renames in "git diff --raw" output#62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 2 commits intogitpython-developers:masterfromPfiver:p2000
Jun 16, 2012

Conversation

@Pfiver
Copy link

potentiallyfixes#36

@Byron
Copy link
Member

Thank you.
Can you please add/update the test suite to verify it is working ?

@Pfiver
Copy link
Author

The tests are passing. However, I had to temporarily add

   @classmethod   def setup_class(cls):           cls.setUpAll()

to the TestDiff class. Otherwise I get an
"AttributeError: 'TestDiff' object has no attribute 'rorepo'" for every test
Any clues on that? What version of nose are you using? I'm using nose 1.1.2 atm.

@Byron
Copy link
Member

I use nosetests version 1.0.0, but I would wonder why they change the API in such a manner that causes tests to break.
Can you also add a diff output containing a rename, and add it to the test suite ?

@Pfiver
Copy link
Author

I have addedhttps://github.com/P2000/GitPython/blob/p2000/git/test/fixtures/diff_rename_raw
andhttps://github.com/P2000/GitPython/blob/p2000/git/test/fixtures/diff_rename
has been already there. Both are in use in git.test.test_diff.TestDiff

Not sure what you mean otherwise?

The nosetest incompatibilites are probably based on different python versions then.
I have been using cpython 2.7 before and now tried with 2.6.
Some tests are still failing but most work now.
What python version are you using?

"$ nosetests":http://sprunge.us/WZYB
"$ nosetests git/test/test_diff.py":http://sprunge.us/GcSf

@Byron
Copy link
Member

I am using python 2.4 to 2.6, these are the versions I am testing with at least.
Besides that, you can ignore the errors I believe, as they relate to a package you have not installed. Of course, these tests should detect that and be skipped automatically, but its not related to this issue.

The master branch is heavily WIP, even though its stale for a while now. Branch 0.3 is the one most people would be using, I wouldn't think that master is in any way ready for production, at least I am not using it in production either.

As there already seem to be rename tests, it should be okay to just merge it in.
Thanks for your effort !

Byron added a commit that referenced this pull requestJun 16, 2012
detect renames in "git diff --raw" output
@ByronByron merged commit864cf1a intogitpython-developers:masterJun 16, 2012
@Pfiver
Copy link
Author

thanks for merging!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do diffs detect renamed files properly?

2 participants

@Pfiver@Byron

[8]ページ先頭

©2009-2025 Movatter.jp