BF: pass original exception into replace_surrogate_encode#603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Byron merged 1 commit intogitpython-developers:masterfromyarikoptic:bf-exc

Mar 8, 2017

Merged

BF: pass original exception into replace_surrogate_encode#603

Byron merged 1 commit intogitpython-developers:masterfromyarikoptic:bf-exc

Mar 8, 2017

Conversation

Copy link

Contributor

yarikoptic commentedMar 8, 2017

Fixes my incorrect fix in#598 ;-)

BF: pass original exception into replace_surrogate_encode

9196b36

Fixes my incorrect fix ingitpython-developers#598

yarikoptic mentioned this pull request

Mar 8, 2017

BF: there is no exc variable, raising NotASurrogateError if that is the right thing todo#598

Merged

Copy link

codecov-io commentedMar 8, 2017

Codecov Report

Merging#603 intomaster willincrease coverage by0.02%.
The diff coverage is33.33%.

@@            Coverage Diff            @@##           master    #603      +/-   ##=========================================+ Coverage   94.48%   94.5%   +0.02%=========================================  Files          63      63                Lines        9961    9961              =========================================+ Hits         9412    9414       +2+ Misses        549     547       -2

Impacted Files	Coverage Δ
git/compat.py	`63.19% <33.33%> (ø)`	✅
git/test/test_repo.py	`97.47% <0%> (+0.33%)`	✅

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update6c6ae79...9196b36. Read thecomment docs.