Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork942
Allow for setting git options, that are persistent across subcommand calls#536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Allow for setting git options, that are persistent across subcommand calls#536
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedOct 18, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Current coverage is 94.45% (diff: 100%)@@ master #536 diff @@========================================== Files 63 63 Lines 9736 9749 +13 Methods 0 0 Messages 0 0 Branches 0 0 ==========================================+ Hits 9193 9208 +15+ Misses 543 541 -2 Partials 0 0
|
| # reset to empty: | ||
| self.git.set_persistent_git_options() | ||
| self.assertRaises(GitCommandError, self.git.NoOp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A minorflake8 reportedby travis:./git/test/test_git.py:175:43: E241 multiple spaces after ','
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Right, forgot this one. Thanks.
@bpoldrack Thanks a lot for your contribution ! I am doing maintenance today, and am confident to manage to put out a new release as well. |
Uh oh!
There was an error while loading.Please reload this page.
Currently
_git_optionsin classGitare reset after each subcommand call. While this is appropriate in most cases, I'm in need to have options for the git executable, that are used with all calls to git on a certain repository and I can't provide this option for each and every call. Therefore I'd like to introduce the possibility to persistently set such options for a given instance ofGit.This is my first PR here, so I'm not exactly sure, what you want me to provide.
CONTRIBUTING.mdreads: "Write a test that fails unless your patch is present."Where am I supposed to put such a test?
Just add it to
git/test/test_git.py?