Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork948
Support Cygwin's Git on Windows#533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Cygwin TCs failing (start, no Cygwin specific code): - PY2: err: 44, fail: 0 - PY3: err: 13, fail: 0
+ Make `Git.polish_url()` convert paths into Cygwin-friendly paths.+ Add utility and soe TCs for funcs for detecting cygwin and convertingabs-paths to `/cygdrive/c/...`.- Cygwin TCs failing: - PY2: err: 14, fail: 3 - PY3: err: 13, fail: 3
+ Rework git-daemon launching with `with` resource-management.+ cmd: add `is_cygwin` optional override kwd on `Git.polish_url()`.- Cygwin TCs failing: - PY2: err: 13, fail: 3 - PY3: err: 12, fail: 3
- Cygwin TCs failing: - PY2: err: 13, fail: 3 - PY3: err: 12, fail: 3
…init- Cygwin TCs failing: - PY2: err: 13, fail: 2 - PY3: err: 12, fail: 2
codecov-io commentedOct 14, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Current coverage is 94.33% (diff: 93.65%)@@ master #533 diff @@========================================== Files 63 63 Lines 9736 9872 +136 Methods 0 0 Messages 0 0 Branches 0 0 ==========================================+ Hits 9193 9313 +120- Misses 543 559 +16 Partials 0 0
|
+ Modify TCs - no main-code changes.+ FIXed: + `TestSubmodule.test_git_submodules_and_add_sm_with_new_commit()` + TestDiff.test_diff_with_staged_file() - Cygwin TCs failing: - PY2: err: 11, fail: 2 - PY3: err: 10, fail: 2
+ Decygpath sm's `.git` file contents.
+ Modify TCs - no main-code changes.+ FIXed: + `TestSubmodule.test_git_submodules_and_add_sm_with_new_commit()` + TestDiff.test_diff_with_staged_file()- Cygwin TCs failing: - PY2: err: 12, fail: 2 - PY3: err: 11, fail: 2
+ Use environment-markers in requirement files (seehttp://stackoverflow.com/a/33451105/548792).
…xed)+ Decygpath sm's `.git` file contents.- Cygwin TCs failing: - PY2: err: 2, fail: 2 - PY3: err: 2, fail: 2
…xed)+ Decygpath sm's `.git` file contents.+ Polish another path in `git add`; actually no main-code changes, justa replace \-->/ on a relative(!) path to make cygwin-git to work.- REGRESSION `test_git_submodules_and_add_sm_with_new_commit` asks foruser/email settings.- Cygwin TCs failing: - PY2: err: 2, fail: 1 - PY3: err: 2, fail: 1
…ide certain 2+2 cases
…ide certain 2+2 cases
…ide certain 2+2 cases
…ide certain 2+2 cases
@Byron you may merge this one, I'm done withWindows, and franky I'm exhausted. I would appreciate if you tried to make an even better summary and add them into CHANGES, to get an overview of my changes needed for making Windows work. |
@ankostis Thanks for the hint ! I just pushed the merge-commit, bringing in all the goodness you have been working on. Thanks so much for all the work you put in, GitPython is so much better now. |
A new release was made. As I felt incapable of summing up the details of the changes concisely, except for general bits about unicode handling and context managers. Thus I ended up praising you, and linked to the respective milestone, hoping that this is alright with you :). |
Uh oh!
There was an error while loading.Please reload this page.
git.util.cygpath()
&git.util.decygpath()
based on material from these 2 resources:+https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx
+https://www.cygwin.com/cygwin-ug-net/using.html#unc-paths
git-daemon
also for Cygwin - reqork it as resource-managed (with
statement.git
commands to inlude'/cygdrive/...'
prefix.git.Repo()
instances to accept also'/cygdrive/...'
paths.Appveyor Cygwin TC failures
Reporting changes in the Appvayor cygwin-combinationbottom-line for significant commits, in reverse chronological order:
git add
commands