Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FIX #526: Do not depend on test-sources#527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ankostis merged 0 commits intogitpython-developers:masterfromankostis:nonose
Oct 11, 2016

Conversation

ankostis
Copy link
Contributor

  • MoveHIDE_WINDOWS_KNOWN_ERRORS flag from
    git.test.lib.helper-->git.util;
    regular modules in main-sources folder also depend on that flag.
  • Use unittest.SkipTest instead of from non-standardnose lib.

@ankostis
Copy link
ContributorAuthor

ankostis commentedOct 11, 2016
edited
Loading

It is strange...in my appveyor project, this PR pases OK:https://ci.appveyor.com/project/ankostis/gitpython/build/1.0.226

[edit] and it is a different commit, from a different branch! (master instead ofnonose)

@codecov-io
Copy link

codecov-io commentedOct 11, 2016
edited
Loading

Current coverage is 93.66% (diff: 81.81%)

Merging#527 intomaster will increase coverage by0.03%

@@             master       #527   diff @@==========================================  Files            63         63            Lines          9652       9651     -1     Methods           0          0            Messages          0          0            Branches          0          0          ==========================================+ Hits           9038       9040     +2+ Misses          614        611     -3  Partials          0          0

Powered byCodecov. Last update9557508...aafde7d

@ankostis
Copy link
ContributorAuthor

There is something fishy going on...I just amended and re-pushed the commit, and still in the Appveyor I'm getting a commit-id that I do not have it in my local repo: cc096ddf

Clicking on to it I see that it is a merge commi, only present on GitHub - but this PR is not yet merged, and actually it is explicitly not based on the latest master, to avoid errors from#513. But this "automatic merge" behavior is defeating my goal.

@ Byron any idea why this is happening?

@ankostisankostisforce-pushed thenonose branch 2 times, most recently fromaafde7d to74c7ed0CompareOctober 11, 2016 16:31
@ankostisankostis merged commit74c7ed0 intogitpython-developers:masterOct 11, 2016
@ankostisankostis deleted the nonose branchOctober 11, 2016 20:57
@ankostisankostis modified the milestone:v2.1.0 - proper windows supportOct 15, 2016
@Byron
Copy link
Member

@ankostis I am looking into the appveyor settings right now - even though I didn't change them at all, maybe there is a checkbox to turn that behaviour off.

@ankostis
Copy link
ContributorAuthor

I don't know either if this auto merge is configurable.
As long as there are no master failures, it won't be a problem B- so you can forget about it.

@Byron
Copy link
Member

Alright - I also didn't find anything - apparently turning this behaviour off is not that easy.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
@ankostis@codecov-io@Byron

[8]ページ先頭

©2009-2025 Movatter.jp