Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork966
FIX #526: Do not depend on test-sources#527
FIX #526: Do not depend on test-sources#527ankostis merged 0 commit intogitpython-developers:masterfrom
Conversation
ankostis commentedOct 11, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It is strange...in my appveyor project, this PR pases OK:https://ci.appveyor.com/project/ankostis/gitpython/build/1.0.226 [edit] and it is a different commit, from a different branch! ( |
codecov-io commentedOct 11, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Current coverage is 93.66% (diff: 81.81%)@@ master #527 diff @@========================================== Files 63 63 Lines 9652 9651 -1 Methods 0 0 Messages 0 0 Branches 0 0 ==========================================+ Hits 9038 9040 +2+ Misses 614 611 -3 Partials 0 0
|
ankostis commentedOct 11, 2016
There is something fishy going on...I just amended and re-pushed the commit, and still in the Appveyor I'm getting a commit-id that I do not have it in my local repo: cc096ddf Clicking on to it I see that it is a merge commi, only present on GitHub - but this PR is not yet merged, and actually it is explicitly not based on the latest master, to avoid errors from#513. But this "automatic merge" behavior is defeating my goal. @ Byron any idea why this is happening? |
aafde7d to74c7ed0CompareByron commentedOct 16, 2016
@ankostis I am looking into the appveyor settings right now - even though I didn't change them at all, maybe there is a checkbox to turn that behaviour off. |
ankostis commentedOct 16, 2016
I don't know either if this auto merge is configurable. |
Byron commentedOct 16, 2016
Alright - I also didn't find anything - apparently turning this behaviour off is not that easy. |
HIDE_WINDOWS_KNOWN_ERRORSflag fromgit.test.lib.helper-->git.util;regular modules in main-sources folder also depend on that flag.
noselib.