Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork966
RF: coveralls (not used/relied on really) -> codecov#522
Merged
Byron merged 1 commit intogitpython-developers:masterfromOct 9, 2016
Merged
RF: coveralls (not used/relied on really) -> codecov#522Byron merged 1 commit intogitpython-developers:masterfrom
Byron merged 1 commit intogitpython-developers:masterfrom
Conversation
codecov in our (datalad, etc) experience provides a better service,great support, and super-nice intergration with chromium and firefoxfor reviewing coverage of pull requests. In light of the@with_rw_directory fiasco detected/fixed ingitpython-developers#521 I would stronglyrecommend to (re-)enable and use coverage reports
codecov-io commentedOct 2, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Current coverage is 86.11% (diff: 100%)
|
Contributor
ankostis commentedOct 2, 2016
That seems cool.@Byron has to decide and implement the change. |
ContributorAuthor
yarikoptic commentedOct 3, 2016
Please let me know if I could be of additional help in persuasion :-) |
391a767 to8a2f7dcCompareMember
Byron commentedOct 9, 2016
No persuasion required :) ! I just want to make sure we get what we need to keep GitPython up and running ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
codecov in our (datalad, etc) experience provides a better service,
great support, and super-nice intergration with chromium and firefox
for reviewing coverage of pull requests. In light of the
@with_rw_directory fiasco detected/fixed in#521 I would strongly
recommend to (re-)enable and use coverage reports
edit 1: I think that if you accept this PR codecov might automagically enable itself on this repo, but I could be wrong and someone with authority might need to login into codecov via github and enable
coverage as seen from my clone:https://codecov.io/gh/yarikoptic/GitPython/commit/94ca83c6b6f49bb1244569030ce7989d4e01495c
and trust me integration with browsers is great! ha -- actually basic (since there were no reports against master -- can't show the difference) report already appeared here (magic!)
If you want to see it in action -- install codecov browser plugin and look e.g. athttps://github.com/datalad/datalad/pull/969/files