BF: allow for other section names which start with a string "remote"#517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Byron merged 1 commit intogitpython-developers:masterfromyarikoptic:bf-remote-sectionname

Sep 24, 2016

Merged

BF: allow for other section names which start with a string "remote"#517

Byron merged 1 commit intogitpython-developers:masterfromyarikoptic:bf-remote-sectionname

Sep 24, 2016

Conversation

Copy link

Contributor

yarikoptic commentedSep 23, 2016

by demanding a space after a word remote, and space is explicitly described as
a delimiter in man git-config:

To begin a subsection put its name in double quotes, separated by space from the section name,

otherwise e.g.

  File "/usr/lib/python2.7/dist-packages/datalad/support/gitrepo.py", line 836, in get_remote_branches    for remote in self.repo.remotes:  File "/home/yoh/deb/gits/python-git/git/repo/base.py", line 271, in remotes    return Remote.list_items(self)  File "/home/yoh/deb/gits/python-git/git/util.py", line 745, in list_items    out_list.extend(cls.iter_items(repo, *args, **kwargs))  File "/home/yoh/deb/gits/python-git/git/remote.py", line 453, in iter_items    raise ValueError("Remote-Section has invalid format: %r" % section)ValueError: Remote-Section has invalid format: u'remotes'

More proper fix I guess could be making a helper function to split any section definition into(section, subsection) tuple and use it throughout the code, since I am afraid there might be similar treatment for other common subsection names

BF: allow for other section names which start with a string "remote"

41fd2c6

by demanding a space after a word remote, and space is explicitly described asa delimiter in man git-config:To begin a subsection put its name in double quotes, separated by space from the section name,otherwise e.g.  File "/usr/lib/python2.7/dist-packages/datalad/support/gitrepo.py", line 836, in get_remote_branches    for remote in self.repo.remotes:  File "/home/yoh/deb/gits/python-git/git/repo/base.py", line 271, in remotes    return Remote.list_items(self)  File "/home/yoh/deb/gits/python-git/git/util.py", line 745, in list_items    out_list.extend(cls.iter_items(repo, *args, **kwargs))  File "/home/yoh/deb/gits/python-git/git/remote.py", line 453, in iter_items    raise ValueError("Remote-Section has invalid format: %r" % section)ValueError: Remote-Section has invalid format: u'remotes'