Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork960
Commit without executing hooks, fixes #468#479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Commit without executing hooks, fixes #468#479
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Byron commentedJun 25, 2016
With the current code-base, it would be a bit cumbersome to test, as you would probably have to check that an actual hook as not been called. Mocking injection seems difficult without a little refactoring. So I guess merging it will just be fine in this case, thanks for your contribution ! |
peterbe commentedJun 26, 2016
Awesome! That's going to really help me. |
Byron commentedJul 17, 2016
Anew release was just pushed to pypi. |
This is a start tofix#468
However, I have no idea where to add tests for this.
I couldn't find any basic test that just tests the commit, with executing hooks. Tips most appreciated.