Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit without executing hooks, fixes #468#479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

peterbe
Copy link
Contributor

This is a start tofix#468

However, I have no idea where to add tests for this.
I couldn't find any basic test that just tests the commit, with executing hooks. Tips most appreciated.

@ByronByron added this to thev2.0.7 - Bugfixes milestoneJun 25, 2016
@Byron
Copy link
Member

With the current code-base, it would be a bit cumbersome to test, as you would probably have to check that an actual hook as not been called. Mocking injection seems difficult without a little refactoring.

So I guess merging it will just be fine in this case, thanks for your contribution !

@ByronByron merged commit4896fa2 intogitpython-developers:masterJun 25, 2016
@peterbe
Copy link
ContributorAuthor

Awesome! That's going to really help me.
So, when will this be in a pypi release?

@Byron
Copy link
Member

Anew release was just pushed to pypi.
Usually you shouldn't have to wait for a release though, as you should always be able to install from the git repository, specifying a tag, commit or branch.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Development

Successfully merging this pull request may close these issues.

Commit without executing hooks
2 participants
@peterbe@Byron

[8]ページ先頭

©2009-2025 Movatter.jp