Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix bug in diff parser output#454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 1 commit intomasterfromfix-octal-escaped-path-parser-bug
May 30, 2016

Conversation

@nvie
Copy link
Contributor

The diff--patch output parser was missing some edge case where Git would encode non-ASCII chars in path names as octals, but these weren't decoded properly.

\360\237\222\251.txt

Decoded via utf-8, that will return:

💩.txt

The diff --patch parser was missing some edge case where Git wouldencode non-ASCII chars in path names as octals, but these weren'tdecoded properly.    \360\237\222\251.txtDecoded via utf-8, that will return:    💩.txt
@nvienvieforce-pushed thefix-octal-escaped-path-parser-bug branch fromcc1c258 to1faf84fCompareMay 30, 2016 13:44
@nvie
Copy link
ContributorAuthor

@Byron This is a bug we've seen in production for some time now. Happy for me to release 2.0.4 with this fix right now?

@ByronByron added this to the v2.0.4 - Bugfixes milestoneMay 30, 2016
@ByronByron merged commitf5089d9 intomasterMay 30, 2016
@Byron
Copy link
Member

No objections, please feel free to make a release.
Something I usually do as well is to keep the milestones in sync, and thus create a new one with the upcoming release, and move all open issues from the just-released milestones into it. The latter can then be closed officially, which will then become another way for the inclined audience to see which issues/PRs made it in there.
Don't feel obliged, as I can do it when I see a disparity, but recently I noticed that I probably have made some mistakes while doing so after the fact.

In any case, thanks for your contribution :) !

@nvienvie deleted the fix-octal-escaped-path-parser-bug branchMay 30, 2016 17:19
@nvie
Copy link
ContributorAuthor

Sure, will do!

@nvie
Copy link
ContributorAuthor

2.0.4 is now up on PyPI :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Development

Successfully merging this pull request may close these issues.

3 participants

@nvie@Byron
[8]ページ先頭
©2009-2025 Movatter.jp