The diff--patch output parser was missing some edge case where Git would encode non-ASCII chars in path names as octals, but these weren't decoded properly.

\360\237\222\251.txt

Decoded via utf-8, that will return:

💩.txt

Fix bug in diff parser output

1faf84f

The diff --patch parser was missing some edge case where Git wouldencode non-ASCII chars in path names as octals, but these weren'tdecoded properly.    \360\237\222\251.txtDecoded via utf-8, that will return:    💩.txt

nvie force-pushed thefix-octal-escaped-path-parser-bug branch fromcc1c258 to1faf84fCompare

May 30, 2016 13:44

Copy link

ContributorAuthor

nvie commentedMay 30, 2016

@Byron This is a bug we've seen in production for some time now. Happy for me to release 2.0.4 with this fix right now?

Byron added this to the v2.0.4 - Bugfixes milestone

May 30, 2016

Byron added the acknowledged label

May 30, 2016

Byron merged commitf5089d9 intomaster

May 30, 2016

Copy link

Member

No objections, please feel free to make a release.
Something I usually do as well is to keep the milestones in sync, and thus create a new one with the upcoming release, and move all open issues from the just-released milestones into it. The latter can then be closed officially, which will then become another way for the inclined audience to see which issues/PRs made it in there.
Don't feel obliged, as I can do it when I see a disparity, but recently I noticed that I probably have made some mistakes while doing so after the fact.

In any case, thanks for your contribution :) !