Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

The progress arg to push, pull, fetch and clone is now a python calla…#450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 2 commits intogitpython-developers:masterfrombarry-scott:master
May 29, 2016

Conversation

barry-scott
Copy link
Contributor

…ble.

This simplifies the API and removes the parser, RemoteProgres,
from the API as RemoteProgress is an internal detail of the implementation.

progress is accepted as:

  • None - drop progress messages
  • callable (function etc) - call the function with the same args as update
  • object - assume its RemoteProgress derived as use as before

RemoteProgress takes an optional progress_function argument.
It will call the progress function if not None otherwise call self.update
as it used to.

…ble.This simplifies the API and removes the parser, RemoteProgres,from the API as RemoteProgress is an internal detail of the implementation.progress is accepted as:* None - drop progress messages* callable (function etc) - call the function with the same args as update* object - assume its RemoteProgress derived as use as beforeRemoteProgress takes an optional progress_function argument.It will call the progress function if not None otherwise call self.updateas it used to.
@barry-scott
Copy link
ContributorAuthor

I'm new to github workflow. The PR is not no master correctly. Not sure of how to redo this.
Let me know if I need to and a hint as to how to rebase now I have pushed this PR please.

@ByronByron added this to the v2.0.4 - Bugfixes milestoneMay 28, 2016
@ByronByron self-assigned thisMay 28, 2016
@Byron
Copy link
Member

Byron commentedMay 28, 2016•
edited
Loading

Thanks for your contribution ! I generally like the way it is implemented, but will make a few line-comments in a moment.
Could you please check and correctthe issuesflake8 has ? Travis has reported issues which are only about the styling of the code. It's possible to run flake8 locally to not have to push to trigger travis, and what many do istox -e flake8 or justflake8 in the root of the project.


messages is '' if there is no additon message.

Deprecated: Pass in a class derived from git.RemoteProgres that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see no reason to deprecate this - it should be fine to just removeDeprecated: here.

@Byron
Copy link
Member

Oh, and before I forget: Could you add the upcoming API improvement in thechanges.rst file please ? Thank you.

@ByronByron merged commitece57af intogitpython-developers:masterMay 29, 2016
Byron added a commit that referenced this pull requestMay 29, 2016
Minor adjustments to PR to match current code style.Related to#450
Byron added a commit that referenced this pull requestMay 29, 2016
Byron added a commit that referenced this pull requestMay 29, 2016
That way, the base type doesn't need any adjustment.Related to#450
@Byron
Copy link
Member

Just to save us some time, I merged and made some modifications myself.
Thanks for your contribution, it's much appreciated.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@ByronByron

Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
@barry-scott@Byron
[8]ページ先頭
©2009-2025 Movatter.jp