Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork940
Ignore progress lines from the git http backend that start w/ POST ...#42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Byron added a commit that referenced this pull requestMay 17, 2012
Ignore progress lines from the git http backend that start w/ POST ...-- gsoltis -- A better way to implement this might be to enumerate the things you do want to count, rather than skipping ones you don't. In the meantime, this fixes the error I ran into on my server.
devdattakulkarni pushed a commit to devdattakulkarni/zuul_messaging that referenced this pull requestFeb 10, 2014
GitPython when fetching refs may improperly read in git progress infoand interpret it as fetch info. When this happens an AssertionError isthrown. However, since fetching seems to cache the ref locallysubsequent fetches work without running into the progress info problem.So fetch again if an AssertionError is caught.Upstream bugfixgitpython-developers/GitPython#42Change-Id: I1768b836aade2853d4dd3b2f4cd1fce7ec035524Reviewed-on:https://review.openstack.org/15219Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>Reviewed-by: James E. Blair <corvus@inaugust.com>Approved: Clark Boylan <clark.boylan@gmail.com>Reviewed-by: Clark Boylan <clark.boylan@gmail.com>Tested-by: Jenkins
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A better way to implement this might be to enumerate the things you do want to count, rather than skipping ones you don't. In the meantime, this fixes the error I ran into on my server.