Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
Add support for getting "aware" datetime info#414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Byron merged 2 commits intogitpython-developers:masterfromnvie:support-full-datetimes-on-commitsApr 20, 2016
Merged
Add support for getting "aware" datetime info#414
Byron merged 2 commits intogitpython-developers:masterfromnvie:support-full-datetimes-on-commitsApr 20, 2016
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This adds 2 properties to commits. Their values are derived from theexisting data stored on them, but this makes them more convenientlyqueryable: - authored_datetime - committed_datetimeThese return "aware" datetimes, so they are effectively companions totheir raw timestamp equivalents, respectively `authored_date` and`committed_date`.These datetime instances are convenient structures since they show theauthor-local commit date and their UTC offset.
Thank you, looks good to me ! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This adds 2 properties to commits. Their values are derived from the existing data stored on them, but this makes them more conveniently queryable:
These return "aware" datetimes, so they are effectively companions to their raw timestamp equivalents, respectively
authored_dateandcommitted_date.These datetime instances are convenient structures since they show the author-local commit date and their UTC offset.
(I've implemented a tzinfo subclass here manually to avoid adding a dependency to dateutil or pytz here.)