Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
Enrich incremental blame output#411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nvie merged 3 commits intogitpython-developers:masterfromnvie:enrich-incremental-blame-outputApr 19, 2016
Merged
Enrich incremental blame output#411
nvie merged 3 commits intogitpython-developers:masterfromnvie:enrich-incremental-blame-outputApr 19, 2016
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Returning this now to avoid having to change the function's return valuestructure later on if we want to emit more information.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds upon the incremental git-blame support, as added in#409. I realized that the previous implementation only returned a subset of all available information from the command's output (only the information I directly needed for my use case). However, that would mean that if we would like to use more of the available blame information, we would need to change the function's returned data structure.
Rather than a
(commit: Commit, linenos: Range)tuple, this now outputs a stream ofBlameEntryinstances. These are named 4-tuples, containing the following fields:commitlinenosorig_pathorig_linenosWhich adds the last 2 fields, providing information on the original filepath / original line numbers for these paths.
Hopefully, this future-proofs the blame_incremental output before the previous implementation gets released and needs to be supported, too.