Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork940
Add incremental blame support#409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Byron merged 2 commits intogitpython-developers:masterfromnvie:add-incremental-blame-supportApr 14, 2016
Merged
Add incremental blame support#409
Byron merged 2 commits intogitpython-developers:masterfromnvie:add-incremental-blame-supportApr 14, 2016
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This adds a sibling method to Repo's blame method: Repo.blame_incremental(rev, path, **kwargs)This can alternatively be called using: Repo.blame(rev, path, incremental=True)The main difference is that blame incremental is a bit more efficientand does not return the full file's contents, just the commits and theline number ranges. The parser is a bit more straight-forward andfaster since the incremental output format is defined a little stricter.
This can be used to pass options like -C or -M.
It seems the commits here are also included in#408 and I might have commented on it. Please feel free to reply anywhere, even though I don't think there is any reason not to merge this one. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a sibling method to Repo's blame method:
This can alternatively be called using:
The main difference is that blame incremental is a bit more efficient and does not return the full file's contents, just the commits and the line number ranges. The parser is a bit more straight-forward and faster since the incremental output format is defined a little stricter.
See the test case for an example.
I've also added support for passing
**kwargsto git-blame, to enable passing-Cor-Mto it.