Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork940
Make sure .read() and friends always return bytes#405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks@nvie , much appreciated ! |
I've fixed the tests as you indicated. I had some trouble running the tests locally (I just tried running Thanks for this awesome project,@Byron! |
Seems all good now :) |
Thanks@nvie ! Testing locally usually fails when you are on a branch. Reason for this is that GitPython uses its own git repository for read-only testing, but doesn't really deal with the edge-cases arising from it. Bad practice, I know :). Besides: I still remember when I was first studying this git-flow page that so neatly visualised the branching scheme that so many are using today ! Thus it's great to have your name in this project's commit history :) ! |
Thanks, that's great to hear. As the matter of fact, we're starting to use more and more of GitPython, and we're seeing some wild repositories, so expect more contributions in the future. First one is#408 :) |
This had tripped me up when consuming from
.read(4096)
in a streaming fashion. All chunks will return bytes except the last one (the empty string), which is a unicode string in Python 3.This fixes that to always return bytes, in both Python 2 and 3.