Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

care tilde in include.path config#309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 2 commits intogitpython-developers:masterfrommihyaeru21:master
Jul 6, 2015
Merged

care tilde in include.path config#309

Byron merged 2 commits intogitpython-developers:masterfrommihyaeru21:master
Jul 6, 2015

Conversation

mihyaeru21
Copy link
Contributor

According to thegit documentation, include.path is subject to tilde expansion.

You can include one config file from another by setting the special include.path variable to the name of the file to be included. The included file is expanded immediately, as if its contents had been found at the location of the include directive. If the value of the include.path variable is a relative path, the path is considered to be relative to the configuration file in which the include directive was found._The value of include.path is subject to tilde expansion_: ~/ is expanded to the value of $HOME, and ~user/ to the specified user’s home directory. See below for examples.

So, I added to care code for tilde expansion.

@Byron
Copy link
Member

Thank you.

Do you think it would be safer to just expand~ if it is the first character ?

@mihyaeru21
Copy link
ContributorAuthor

Yes.
I think usinginclude_path.startswith('~') is safer than using'~' in include_path.
(e.g. zsh and bash expand~/, but they doesn't expand/~)

I will fix it.
Thank you!

@Byron
Copy link
Member

Cool, please leave a quick note here once it's done as I don't get notifications if a new commit comes in.
Thanks again.

@mihyaeru21
Copy link
ContributorAuthor

fixed!

Byron added a commit that referenced this pull requestJul 6, 2015
care tilde in include.path config
@ByronByron merged commitc5e4334 intogitpython-developers:masterJul 6, 2015
@Byron
Copy link
Member

Thanks a lot !

@mihyaeru21
Copy link
ContributorAuthor

Thanks too!!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v1.0.2 - Fixes
Development

Successfully merging this pull request may close these issues.

2 participants
@mihyaeru21@Byron

[8]ページ先頭

©2009-2025 Movatter.jp