Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork940
While parsing errors, also detecting lines starting with "error:"#297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Reverted changes of `fe2fbc5~2`.This caused `git-pull` to error, which now actually results in a fatalerror while fetching or pulling. Previously we simply didn't checkfor this issue.Now we are back to a `poll` based or threaded concurrent reading fromstdout and stderr to prevent a git process deadlock, and theaforementioned error.Related to#297
Thank you ! This actually caused a 'sleeping' issue to show itself, which is now fixed as well. Of course I can only hope this doesn't cause breakage elsewhere, but at least the test-suite is happy with it. |
You can watch the development streamon youtube.
|
Thanks! Great that i found that latent bug ;) |
Rigth now only the word "fatal:" is being checked but there are also errors that start with "error:", for example:
$ git pull origin master
From github.host.com/mycompany/repo
Updating 49d7506..7de461c
error: Your local changes to the following files would be overwritten by merge:
mydir/myfile.txt
Please, commit your changes or stash them before you can merge.
Aborting