Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork960
Allow submodules to be ignored in is_dirty#294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There are cases when might not consider a directory dirty when a submodule haschanges. Particular case was git-up stashing changes where submodules areirrelevant.
Submodule changes cannot be stashed and thus should not be considered whenstashing changes. Requiresgitpython-developers/GitPython#294 to be appliedfirst.
* renamed `consider_submodules` to `submodules` to be in line with the existing parameters. Nowadays I would prefer the `consider_` prefix, but can't change the existing API and thus stick to the current naming scheme.* reduced amount of code in one portion to make it more maintainable.Related to#294
Byron commentedJun 10, 2015
Thank you very much ! |
Byron commentedJun 10, 2015
You can watch the development streamon youtube.
|
Javex commentedJun 10, 2015
The youtube thing was great :) Nice to hear some comments on the PR. You could of course have asked, even if 5 days have passed, I would have gladly made the changes. Thanks for being so quick in merging the request. |
The pull requestgitpython-developers/GitPython#294 has been merged but the APIwas changed slighty. This commit reflects this change so that it works again.
I had a use case withPyGitUp where I did not want submodules to be considered when asking whether a repo is dirty. This change allows that. I am a bit unsure with the "untracked_files" part: I would think that it's not necessary, as I can't imagine an untracked submodule (how would that work? Git would not see it as a submodule), but I included this change anyway. I can of course revert it if you are sure that there can't be a relevant case.
One problem though: I could not run (and thus not write) tests as even the most current tag had test failures for me on Python 2.7.
Please let me know what you think.