Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
Store path attribute on Diff object#266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
If a file in a commit contains no changes (for example, if only thefile mode is changed) there will be no blob attached. This isusually where the filename is stored, so without it, the callingcontext can not tell what file was changed. Instead, alwaysstore a_path and b_path on the Diff object so that informationis available.
Byron added a commit that referenced this pull requestMar 2, 2015
Store path attribute on Diff object
Thank you :) ! If travis is green, I am green too ! |
jeblair added a commit to openstack-archive/gertty that referenced this pull requestMar 5, 2015
If a file only has mode differences, but no content difference,we do not have access through GitPython to find out the filenames.gitpython-developers/GitPython#266 hasbeen submitted to correct that, but in the mean time, display"Unknown File" to avoid crashing.Change-Id: Ic935f9737ae3978a7a639408c24f166c76a2c999Story: 2000027
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a file in a commit contains no changes (for example, if only the
file mode is changed) there will be no blob attached. This is
usually where the filename is stored, so without it, the calling
context can not tell what file was changed. Instead, always
store a_path and b_path on the Diff object so that information
is available.