Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

encode name of actor to utf-8#215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

niyaton
Copy link
Contributor

I found we cannot write log message to reflog in UTF-8 in python 2.7.5.
We can easily to reproduce this bug by executing following code to empty repository.

repo=Repo(path_to_repository)repo.create_head('test_head',logmsg='日本語')

In my environment, this code will throw following error:

UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 0: ordinal not in range(128)

I think this bug was introduced by4a7e7a7 and28fdf05.

I hope this PR fix this bug.

@ByronByron added this to thev0.3.4 - python 3 support milestoneDec 11, 2014
@Byron
Copy link
Member

Thank you.
GitPython doesn't handle unicode properly, which is due to be fixed when providing support for python 3.

In the meanwhile, it shouldn't hurt to merge this PR.

Byron added a commit that referenced this pull requestDec 11, 2014
@ByronByron merged commit891b124 intogitpython-developers:0.3Dec 11, 2014
@niyaton
Copy link
ContributorAuthor

Thank you for quick merge!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
@niyaton@Byron
[8]ページ先頭
©2009-2025 Movatter.jp