Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Handle relativeinclude.path when root config is provided as a relative path#2104

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/test-and-fix-issue-2103
Draft

Handle relativeinclude.path when root config is provided as a relative path#2104
Copilot wants to merge 2 commits intomainfrom
copilot/test-and-fix-issue-2103

Conversation

Copy link

CopilotAI commentedFeb 25, 2026
edited
Loading

Git config allows relative include paths to be resolved relative to the config file containing the directive. GitPython currently asserts the source config path is absolute during include resolution, which raisesAssertionError for valid setups when the parser is initialized with a relative config path.

  • What changed

    • Updated include resolution inGitConfigParser.read() to normalize the current config file path to absolute when needed before resolving relative includes.
    • Removed the absolute-path assertion that caused valid relative-path configurations to fail.
  • Regression coverage

    • Added a focused test intest/test_config.py to verify:
      • main config includespath = b
      • main config is opened via a relative path
      • included values are successfully loaded fromb
  • Behavioral impact

    • Relative include semantics now align with git’s documented behavior even when the initial config path passed toGitConfigParser is relative.
    • Existing include cycle/seen-path handling remains unchanged.
# before: could raise AssertionError if main config path is relativewithGitConfigParser(os.path.relpath(main_cfg),read_only=True)ascr:cr.get_value("section","key")# now: relative include in main_cfg resolves correctly

✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Byron <63622+Byron@users.noreply.github.com>
CopilotAI changed the title[WIP] Test and fix issue with GitPython functionalityHandle relativeinclude.path when root config is provided as a relative pathFeb 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Byron

[8]ページ先頭

©2009-2026 Movatter.jp