Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Allow relative path url in submodules for submodule_update#2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@t-webber
Copy link
Contributor

fixes#944

@t-webbert-webberforce-pushed therelative_path_submodules branch from545618e toec2e2c8CompareJuly 22, 2025 10:27
Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for contributing!

I think with a test this can be merged. Maybe looking at the existing tests for submodules can help to set one up.

Thanks again.

@t-webbert-webber requested a review fromByronJuly 23, 2025 05:25
Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot, this is great!

Something I'd like to also know is what happens if the submodule is 'hidden', and the URL starts with a.. This would mean the submodule resides within the parent repository, but is added as submodule under a different path.
Is this is a thing even? If you think so, please do feel free to contribute the respective test as well, but let's not block this PR on such an edge-case.

@ByronByron merged commitbbb3d00 intogitpython-developers:mainJul 24, 2025
27 checks passed
@t-webber
Copy link
ContributorAuthor

I am not sure I understand your question.

When you rungit add ../../other/repo without specifying the path, git adds a default ofrepo aspath in.gitmodules, so still in the same folder.

If you try and remove the path argument, you get an error when trying to update the submodule. You have the same error if the submodule has an absolute path. Git seems to always want a path and a URL field in the.gitmodules file.

@t-webbert-webber deleted the relative_path_submodules branchJuly 24, 2025 06:32
@Byron
Copy link
Member

Please don't mind it, it's not too important I think.

Thanks again for contributing this fix and a test🙏.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ByronByronByron approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

submodule update doesn't work with relative submodule paths (in GitPython 2.1.14)

2 participants

@t-webber@Byron
[8]ページ先頭
©2009-2025 Movatter.jp