Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork960
Allow relative path url in submodules for submodule_update#2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Allow relative path url in submodules for submodule_update#2062
Conversation
545618e toec2e2c8CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot for contributing!
I think with a test this can be merged. Maybe looking at the existing tests for submodules can help to set one up.
Thanks again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot, this is great!
Something I'd like to also know is what happens if the submodule is 'hidden', and the URL starts with a.. This would mean the submodule resides within the parent repository, but is added as submodule under a different path.
Is this is a thing even? If you think so, please do feel free to contribute the respective test as well, but let's not block this PR on such an edge-case.
bbb3d00 intogitpython-developers:mainUh oh!
There was an error while loading.Please reload this page.
I am not sure I understand your question. When you run If you try and remove the path argument, you get an error when trying to update the submodule. You have the same error if the submodule has an absolute path. Git seems to always want a path and a URL field in the |
Please don't mind it, it's not too important I think. Thanks again for contributing this fix and a test🙏. |
fixes#944