Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork942
fix updating submodules with relative urls#2051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix updating submodules with relative urls#2051
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This fixes running repo.update_submodules(init=True) on repositoriesthat are using relative for the modules.Fixesgitpython-developers#730
76f3bf3 to1d80891CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot!
Even though I cannot truly say I know this is correct, there is a test that would probably fail with an exception without the fix so it's better than before.
7677c05 intogitpython-developers:mainUh oh!
There was an error while loading.Please reload this page.
This fixes running repo.update_submodules(init=True) on repositories that are using relative for the modules.
It tries to emulate the git behavior:https://github.com/git/git/blob/master/builtin/submodule--helper.c#L503
Fixes#730