Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork960
Fix ambiguous_safer_popen_windows comment#2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This fixes some ambiguous wording in a comment in`_safer_popen_wording`, where it was unclear if the secondaryproblem -- where it would be possible to run a wrong `cmd.exe`-typeshell -- would happen under two separate circumstances, or onlywhen both circumstances occurred together. This adjusts its wordingto make clear that it is the latter.This also fixes a minor typo in another `_safer_popen_windows`comment.This might be viewed as building on the improvements inb9d9e56(gitpython-developers#1859), but the changes here are to comments only.
b6a188b intogitpython-developers:main 27 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This fixes some ambiguous wording in a comment in
_safer_popen_wording, where it was unclear if the secondary problem – where it would be possible to run a wrongcmd.exe-type shell – would happen under two separate circumstances, or only when both circumstances occurred together. This adjusts its wording to make clear that it is the latter.This also fixes a minor typo in another
_safer_popen_windowscomment.This might be viewed as building on the improvements inb9d9e56 (#1859), but the changes here are to comments only.
(I'll merge this once CI passes on it.)