Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork941
Fix CImypy
command on free-threaded Python#2040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
EliahKagan merged 2 commits intogitpython-developers:mainfromEliahKagan:mypy-free-threadedJun 7, 2025
Merged
Fix CImypy
command on free-threaded Python#2040
EliahKagan merged 2 commits intogitpython-developers:mainfromEliahKagan:mypy-free-threadedJun 7, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When the version is represented as `3.13t`, the `--python-version`option needs an operand of `3.13`, not `3.13t`.(This, and the fix here, will automatically apply to later threadedPythons, such as 3.14t, too.)
Since the `${var%pattern}` syntax may not be immediately obvious.
27bf23c
intogitpython-developers:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
When the version is represented as
3.13t
, the--python-version
option needs an operand of3.13
, not3.13t
.(This, and the fix here, will automatically apply to later threaded Pythons, such as 3.14t, too.)
Before this change,in the Python 3.13t run:
This isn't new--it's always happened in the
mypy
step in the 3.13t job. We just never noticed it, because themypy
step always reports failure even when working correctly, because there are a number of unresolved type errors, most of which should not be suppressed but that neither I nor others have get gotten around yet to fixing, and some of which maybe should be suppressed but neither I nor others have gotten around yet to verifying are reasonable to suppress. (For quite some time, themypy
step has step-levelcontinue-on-error
, which causes it not to fail the job.)There's no connection between this and#2037 or#2038/#2039, except in the broad conceptual sense that this and#2038 share as a contributing factor that it's easy not to notice unanticipated new problems with
mypy
. However, just in case, I have verified that the effect of#2039 applies the same to 3.13t as to 3.13, by first testing this on a feature branch that had not integrated#2039, and then rebasing.No change is needed in
tox.ini
, even separately from that not yet listing apy313t
environment, becausetox.ini
as currently written does not pass a--python-version
argument tomypy
.I plan to merge this once everything passes on CI, after also verifying again that the output is as expected.
Edit: The effect is as expected and intended. I'll just wait for the rest of CI to pass before merging.