#2035 fixed issue#1923 by removing separate double quotation marks appearing on a single-line configuration variable when parsing a configuration file. However, as noted in#2035 (comment), it also stripped leading and trailing whitespace from the string obtained by removing the quotes.

In this PR:

5f30320 adds a test case of a plausible--and in my view, decisive--scenario where such whitespace needs to be preserved and where a user would almost certainly expect it to preserve. This test would also have failed before#2035, due to the absence of quote removal. But it is the sort of value that one would expect to parse correctly now that#1923 is fixed, and which#2035almost does parse correctly.
bd2b930 fixes the case by removing thestrip() call while leaving the changes from#2035 otherwise intact. The test added in (1) fails until this change, and then passes.

See the commit message for further details.

EliahKagan added2 commits

June 7, 2025 01:22

Test a quoted config var with meaningful edge whitespace

5f30320

gitpython-developers#2035 fixed issuegitpython-developers#1923 by removing separate double quotation marksappearing on a single-line configuration variable when parsing aconfiguration file. However, it also stripped leading and trailingwhitespace from the string obtained by removing the quotes.This adds a test case of a plausible scenario where such whitespaceneeds to be preserved and where a user would almost certainly expectit to preserve: setting a value like `# ` for `core.commentString`,in order to be able to easily create commit messages like this one,that contain a line that begins with a literal `#`, while stillletting `#` in the more common case that it is followed by a spacebe interpreted as a comment.The effect of  `git config --local core.commentString '# '` is toadd a `commentString = "# "` line in the `[core]` section of`.git/config`. The changes ingitpython-developers#2035 allow us to correctly parsemore quoted strings than before, and almost allow us to parse this,but not quite, because of the `strip()` operation that turns `# `into `#`.

Preserve quoted leading and trailing single-line whitespace

bd2b930

At least in a single line, whitespace in a double-quoted value in aconfiguration file, like `name = " abc def "`, would presumably beintended. This removes the `strip()` call that is applied to text`ConfigParser` obtained by removing the double quotes around it.This slightly refines the changes ingitpython-developers#2035 by dropping the `strip()`call while continuing to remove opening and closing double quotes.