Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
Specify explicitcontents: read workflow permissions#2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Three CI workflows that need only `contents: read` permissions andno other permissions did not have explicit permissions set, andwould therefore be given default permissions configured for therepository, which might be more expansive than the workflows need.It is recommended to set explicit workflow permissions [1]. Thisdoes that, specifying permissions as `pythonpackage.yml` alreadydid, and closing three `actions/missing-workflow-permissions`CodeQL alerts (new sincegitpython-developers#2032 enabled scanning of GHA workflows).[1]:https://codeql.github.com/codeql-query-help/actions/actions-missing-workflow-permissions/
751cb2d intogitpython-developers:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
EliahKagan added a commit to EliahKagan/gitdb that referenced this pull requestMay 30, 2025
This change is analogous togitpython-developers/GitPython#2033.See alsogitpython-developers/smmap#60.
EliahKagan added a commit to EliahKagan/smmap that referenced this pull requestMay 30, 2025
This change is analogous togitpython-developers/GitPython#2033.See alsogitpython-developers/gitdb#121.
This was referencedMay 30, 2025
EliahKagan added a commit to EliahKagan/gitdb that referenced this pull requestMay 30, 2025
This change is analogous togitpython-developers/GitPython#2033.See alsogitpython-developers/smmap#60.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Specify explicit
contents: readworkflow permissionsThree CI workflows that need only
contents: readpermissions and no other permissions did not have explicit permissions set, and would therefore be given default permissions configured for the repository, which might be more expansive than the workflows need.It is recommended to set explicit workflow permissions. This does that, specifying permissions as
pythonpackage.ymlalready did, and closing threeactions/missing-workflow-permissionsCodeQL alerts (new since#2032 enabled scanning of GHA workflows).I'll merge this once I verify that all CI checks still pass.