Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork947
Use newer ruff style#2031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Use newer ruff style#2031
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This updates `ruff` in `.pre-commit-config.yaml` from 0.6.0 to0.11.12, changes its `id` from the legacy `ruff` alias to`ruff-check` (which is better distinguished from `ruff-format`,which we also have a hook for), and applies the few style changesit newly recommends throughout the code. The style changes seem tomake things slightly clearer overall.This also updates some other pre-commit hooks, but those don'trequire any changes to the code.Currently the `ruff` dependency in `requirements-dev.txt` doesn'tspecify a version, so no change is needed there. This update maybe seen as bringing the `pre-commit` version in line with whatusers will usually have locally with `pip install -e ".[test]"`.The `pre-commit` hooks are how linting is currently done on CI, sothis is updating `ruff` for CI. That's the most significant effectof this change. (`pre-commit` is run for linting on CI probablymuch more often than it is used locally, to manage pre-commithooks or otherwise, in GitPython development.)
2d662cc
intogitpython-developers:main 25 checks passed
Uh oh!
There was an error while loading.Please reload this page.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestJun 8, 2025
This resolves two warnings about Ruff configuration, by:- No longer setting `ignore-init-module-imports = true` explicitly, which was deprecated since `ruff` 0.4.4. We primarily use `ruff` via `pre-commit`, for which this deprecation has applied since we upgraded the version in `.pre-commit-config.yaml` from 0.4.3 to 0.6.0 ind1582d1 (gitpython-developers#1953). We continue to list `F401` ("Module imported but unused") as not automatically fixable, to avoid inadvertently removing imports that may be needed. See also:https://docs.astral.sh/ruff/settings/#lint_ignore-init-module-imports- Rename the rule `TCH004` to `TC004`, since `TCH004` is the old name that may eventually be removed and that is deprecated since 0.8.0. We upgraded `ruff` in `.pre-commit-config.yml` again inb7ce712 (gitpython-developers#2031), from 0.6.0 to 0.11.12, at which point this deprecation applied. See alsohttps://astral.sh/blog/ruff-v0.8.0.These changes make those configuration-related warnings go away,and no new diagnostics (errors/warnings) are produced when running`ruff check` or `pre-commit --all-files`. No F401-relateddiagnostics are triggered when testing with explicit`ignore-init-module-imports = false`, in preview mode or otherwise.This commit also adds the version lower bound `>=0.8` for `ruff` in`requirements-dev.txt`. (That file is rarely used, as noted ina8a73ff (gitpython-developers#1871), but as long as we have it, there may be a benefitto excluding dependency versions for which our configuration is nolonger compatible.)
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestJun 8, 2025
This resolves two warnings about Ruff configuration, by:- No longer setting `ignore-init-module-imports = true` explicitly, which was deprecated since `ruff` 0.4.4. We primarily use `ruff` via `pre-commit`, for which this deprecation has applied since we upgraded the version in `.pre-commit-config.yaml` from 0.4.3 to 0.6.0 ind1582d1 (gitpython-developers#1953). We continue to list `F401` ("Module imported but unused") as not automatically fixable, to avoid inadvertently removing imports that may be needed. See also:https://docs.astral.sh/ruff/settings/#lint_ignore-init-module-imports- Rename the rule `TCH004` to `TC004`, since `TCH004` is the old name that may eventually be removed and that is deprecated since 0.8.0. We upgraded `ruff` in `.pre-commit-config.yml` again inb7ce712 (gitpython-developers#2031), from 0.6.0 to 0.11.12, at which point this deprecation applied. See alsohttps://astral.sh/blog/ruff-v0.8.0.These changes make those configuration-related warnings go away,and no new diagnostics (errors/warnings) are produced when running`ruff check` or `pre-commit run --all-files`. No F401-relateddiagnostics are triggered when testing with explicit`ignore-init-module-imports = false`, in preview mode or otherwise.In addition, this commit makes two changes that are not needed toresolve warnings:- Stop excluding `E203` ("Whitespace before ':'"). That diagnostic is no longer failing with the current code here in the current version of `ruff`, and code changes that would cause it to fail would likely be accidentally mis-st- Add the version lower bound `>=0.8` for `ruff` in `requirements-dev.txt`. That file is rarely used, as noted ina8a73ff (gitpython-developers#1871), but as long as we have it, there may be a benefit to excluding dependency versions for which our configuration is no longer compatible. This is the only change in this commit outside of `pyproject.toml`.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This updates
ruff
in.pre-commit-config.yaml
from 0.6.0 to 0.11.12, changes itsid
from the legacyruff
alias toruff-check
(which is better distinguished fromruff-format
, which we also have a hook for), and applies the few style changes it newly recommends throughout the code. The style changes seem to make things slightly clearer overall.This also updates some other pre-commit hooks, but those don't require any changes to the code.
Currently the
ruff
dependency inrequirements-dev.txt
doesn't specify a version, so no change is needed there. This update may be seen as bringing thepre-commit
version in line with what users will usually have locally withpip install -e ".[test]"
.The
pre-commit
hooks are how linting is currently done on CI, so this is updatingruff
for CI. That's the most significant effect of this change. (pre-commit
is run for linting on CI probably much more often than it is used locally, to manage pre-commit hooks or otherwise, in GitPython development.)This works locally andon CI, but I'll still wait for all checks to pass before merging.