Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
correctly handleuname-cmd that doesn't point to an executable file#2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
…re trying to run it"This reverts commitde5e57c.
… it could both exist and have os.X_OK but not work
honestly, after having written this code, I'm not sure why we're not just delegating |
see#2027 for a different implementation of the same basic logic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR fixes the handling of cases where the uname command (used to detect Cygwin Git) is not an executable file and adds unit tests for verifying the behavior of is_cygwin_git. It also includes an update to the AUTHORS file to add a new contributor.
- Updated test_util.py to add tests for is_cygwin_git.
- Revised git/util.py to check if uname_cmd is an executable file before invoking it.
- Updated AUTHORS list.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/test_util.py | Added unit tests for is_cygwin_git functionality |
| git/util.py | Updated uname command executable check and caching logic |
| AUTHORS | Added new contributor |
Uh oh!
There was an error while loading.Please reload this page.
Thanks for contributing a fix! Indeed, I don't know why we are in the current place, but@EliahKagan probably has more information and I hope he can chime in. Besides that, my apologies, I did click the "copilot" review button out of curiosity, please feel free to completely ignore it. |
I also ran into the issue from#1979. My proposed solution is that
GitPythonshould only try to rununame_cmdif it points to an executable file. I also wrote a short test class for theis_cygwin_gitfunction. I don't have a machine with Cygwin, so I can't test that it actually does work, but I trust thePython docs when they say that on Cygwin,sys.platformwill becygwin.