Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
IndexFile._to_relative_path - fix case where absolute path gets stripped of trailing slash#2012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
2bbb6ee to3a40c1cCompare
kelibezhani left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
…ipped of trailing slash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great, thanks a lot for the fix!
Looks good to me, too!
e85a895 intogitpython-developers:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
I encountered this issue on MacOS, python 3.7 and later
Added fix and appropriate unit test.
Stripping of trailing slash seems to be happening in
os.path.relpath, altough I am not sure whether that is expected behaviour. In case it is not expected, and ever gets fixed, I added an additional check (and not result.endswith(os.sep)) to make sure that the trailing slash doesn't get duplicated.