Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Test free-threaded Python (but only on Linux)#2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 2 commits intogitpython-developers:mainfromEliahKagan:nogil
Mar 12, 2025

Conversation

EliahKagan
Copy link
Member

@EliahKaganEliahKagan commentedMar 7, 2025
edited
Loading

Fixes#2005

See commit messages for details:

  • f1dbe33 describes why this uses the approach of using a different action (rather than@main or@... where... is an OID) for the3.13t job, and why that is expressed by splitting the step instead of introducing a new matrix variable.
  • fd78857 describes why this only introduces it for Linux. The reason is not entirely the same as proposed in#2005, since it turns out that testing on other systems--in the way we do so here--works without any special effort.

(As elsewhere, due to#2004, the Cygwin test job should be expected to fail here until#2009 is merged. That is not related to the changes here.)

@EliahKaganEliahKagan changed the titleTest on free-threaded Python on LinuxTest free-threaded Python on Linux (but only on Linux)Mar 7, 2025
@EliahKaganEliahKagan changed the titleTest free-threaded Python on Linux (but only on Linux)Test free-threaded Python (but only on Linux)Mar 7, 2025
@EliahKaganEliahKagan marked this pull request as ready for reviewMarch 7, 2025 04:02
Seegitpython-developers#2005. Right now, this does not limit by operating system, butthat is just to verify that there are no OS-specific 3.13t problemswe should know about right now; once that is verified, the macOSand Windows jobs will be removed (excluded) for the time being.The 3.13t jobs added here use `Quansight-Labs/setup-python`, not`actions/setup-python`. The latter also has the ability to use3.13t sinceactions/python-versions#319andactions/setup-python#973 (see alsoactions/setup-python#771), but no versiontag includes this feature yet. It can be used by using `@main` or`@...` where `...` is an OID. The former would risk pulling inother untested features we're no trying to test with, while thelatter would not be easy to upgrade automatically as what we havenow (we would be deliberately keeping a hash not at any tag that isalready not the latest hash on any branch). In contrast, the`Quansight-Labs/setup-python` fork adds this feature while stayingup to date with others. When `actions/setup-python` has a release(stable or prerelease) with this feature, we can switch to it.This could probably be done with less code duplication by using amatrix variable for the action to use. Instead, the "Set up Python"step is split in two, with opposite `if` conditions, so that eachis capable of being recognized and upgraded by Dependabot if a newmajor version is released (in case this ends up remaining in placelonger than expected).
For now, this omits macOS and Windows from the 3.13t ("threaded")tests.The plan ingitpython-developers#2005 is to start without them, and no OS-specificproblems have been identified so far. In particular, in theprevious commit that adds 3.13t without excluding any operatingsystems, all tests in the macOS job passed as expected, and theWindows job had the same failure with the same message as ingitpython-developers#1955,with no XFAIL changed to XPASS (which, if present, would suggestGC differences meriting further exploration of 3.13t on Windows).
@ByronByron merged commit6d09bb6 intogitpython-developers:mainMar 12, 2025
25 checks passed
@EliahKaganEliahKagan deleted the nogil branchMarch 12, 2025 20:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should test with free-threaded interpreter on CI
2 participants
@EliahKagan@Byron

[8]ページ先頭

©2009-2025 Movatter.jp