Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Test free-threaded Python (but only on Linux)#2011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Seegitpython-developers#2005. Right now, this does not limit by operating system, butthat is just to verify that there are no OS-specific 3.13t problemswe should know about right now; once that is verified, the macOSand Windows jobs will be removed (excluded) for the time being.The 3.13t jobs added here use `Quansight-Labs/setup-python`, not`actions/setup-python`. The latter also has the ability to use3.13t sinceactions/python-versions#319andactions/setup-python#973 (see alsoactions/setup-python#771), but no versiontag includes this feature yet. It can be used by using `@main` or`@...` where `...` is an OID. The former would risk pulling inother untested features we're no trying to test with, while thelatter would not be easy to upgrade automatically as what we havenow (we would be deliberately keeping a hash not at any tag that isalready not the latest hash on any branch). In contrast, the`Quansight-Labs/setup-python` fork adds this feature while stayingup to date with others. When `actions/setup-python` has a release(stable or prerelease) with this feature, we can switch to it.This could probably be done with less code duplication by using amatrix variable for the action to use. Instead, the "Set up Python"step is split in two, with opposite `if` conditions, so that eachis capable of being recognized and upgraded by Dependabot if a newmajor version is released (in case this ends up remaining in placelonger than expected).
For now, this omits macOS and Windows from the 3.13t ("threaded")tests.The plan ingitpython-developers#2005 is to start without them, and no OS-specificproblems have been identified so far. In particular, in theprevious commit that adds 3.13t without excluding any operatingsystems, all tests in the macOS job passed as expected, and theWindows job had the same failure with the same message as ingitpython-developers#1955,with no XFAIL changed to XPASS (which, if present, would suggestGC differences meriting further exploration of 3.13t on Windows).
6d09bb6
intogitpython-developers:main 25 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#2005
See commit messages for details:
@main
or@...
where...
is an OID) for the3.13t
job, and why that is expressed by splitting the step instead of introducing a new matrix variable.(As elsewhere, due to#2004, the Cygwin test job should be expected to fail here until#2009 is merged. That is not related to the changes here.)