Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Marktest_installation xfail on Cygwin CI#2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

EliahKagan
Copy link
Member

@EliahKaganEliahKagan commentedMar 6, 2025
edited
Loading

Together with#2007, this works around#2004, allowing all tests to pass on Cygwin CI.

In#2007, installation of the environment in which tests run was fixed by downloading and running theget-pip.py bootstrap script. If we were to modify our helper that sets up the (separate) virtual environment intest_installation so that it does the same thing (or conditionally does so on CI, since the problem does not seem to happen in local installations), that would likely "fix" this more thoroughly, allowing the test to pass.

But part of the goal of the installation test is to test that installation works in a typical environment on the platform it runs on. So it is not obivous that making it pass in that way would be an improvement compared to marking itxfail with the exception type that occurs due to#2004. So this just does that, for now.

I don't know if this should be considered toclose#2004 or not.

Together withgitpython-developers#2007, this works aroundgitpython-developers#2004, allowing all tests topass on Cygwin CI.Ingitpython-developers#2007, installation of the environment in which tests run wasfixed by downloading and running the `get-pip.py` bootstrap script.If we were to modify our helper that sets up the (separate) virtualenvironment in `test_installation` so that it does the same thing(or conditionally does so on CI, since the problem does not seem tohappen in local installations), that would likely "fix" this morethoroughly, allowing the test to pass.But part of the goal of the installation test is to test thatinstallation works in a typical environment on the platform it runson. So it is not obivous that making it pass in that way would bean improvement compared to marking it `xfail` with the exceptiontype that occurs due togitpython-developers#2004. So this just does that, for now.
@Byron
Copy link
Member

Thanks a lot for your valuable support.

I don't know if this should be considered to close#2004 or not.

Generally I am leaning towards closing it to see if a user will submit a related issue.

EliahKagan reacted with thumbs up emoji

@ByronByron merged commitd06f8a9 intogitpython-developers:mainMar 12, 2025
24 checks passed
@EliahKaganEliahKagan deleted the cygwin-xfail-ci branchMarch 12, 2025 11:49
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestJun 14, 2025
This installs the `python-pip-wheel`, `python-setuptools-wheel`,and `python-wheel-wheel` packages on Cygwini CI, which provide`.whl` files for `pip`, `setuptools`, and `wheel`.By making those wheels available, thisfixesgitpython-developers#2004 better than theprevious workaround, allowing `ensurepip` to run without the error:    Traceback (most recent call last):      File "/usr/lib/python3.9/runpy.py", line 188, in _run_module_as_main        mod_name, mod_spec, code = _get_module_details(mod_name, _Error)      File "/usr/lib/python3.9/runpy.py", line 147, in _get_module_details        return _get_module_details(pkg_main_name, error)      File "/usr/lib/python3.9/runpy.py", line 111, in _get_module_details        __import__(pkg_name)      File "/usr/lib/python3.9/ensurepip/__init__.py", line [30](https://github.com/EliahKagan/GitPython/actions/runs/13454947366/job/37596811693#step:10:31), in <module>        _SETUPTOOLS_VERSION = _get_most_recent_wheel_version("setuptools")      File "/usr/lib/python3.9/ensurepip/__init__.py", line 27, in _get_most_recent_wheel_version        return str(max(_wheels[pkg], key=distutils.version.LooseVersion))    ValueError: max() arg is an empty sequenceThis change takes the place of the main changes ingitpython-developers#2007 andgitpython-developers#2009.In particular, it should allow `test_installation` to pass again.This also delists non-wheel Cygwin packages such as `python39-pip`,which are not needed (or at least no longer needed).
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestJun 14, 2025
This installs the `python-pip-wheel`, `python-setuptools-wheel`,and `python-wheel-wheel` packages on Cygwini CI, which provide`.whl` files for `pip`, `setuptools`, and `wheel`.By making those wheels available, thisfixesgitpython-developers#2004 better than theprevious workaround, allowing `ensurepip` to run without the error:    Traceback (most recent call last):      File "/usr/lib/python3.9/runpy.py", line 188, in _run_module_as_main        mod_name, mod_spec, code = _get_module_details(mod_name, _Error)      File "/usr/lib/python3.9/runpy.py", line 147, in _get_module_details        return _get_module_details(pkg_main_name, error)      File "/usr/lib/python3.9/runpy.py", line 111, in _get_module_details        __import__(pkg_name)      File "/usr/lib/python3.9/ensurepip/__init__.py", line [30](https://github.com/EliahKagan/GitPython/actions/runs/13454947366/job/37596811693#step:10:31), in <module>        _SETUPTOOLS_VERSION = _get_most_recent_wheel_version("setuptools")      File "/usr/lib/python3.9/ensurepip/__init__.py", line 27, in _get_most_recent_wheel_version        return str(max(_wheels[pkg], key=distutils.version.LooseVersion))    ValueError: max() arg is an empty sequenceThis change takes the place of the main changes ingitpython-developers#2007 andgitpython-developers#2009.In particular, it should allow `test_installation` to pass again.This also delists non-wheel Cygwin packages such as `python39-pip`,which are not needed (or at least no longer needed).(The python-{pip,setuptools,wheel}-wheel packages are, as theirnames suggest, intentionally not specific to Python 3.9. However,this technique will not necessarily carry over to Python 3.12,depending on what versions are supplied and other factors. This maybe relevant when another attempt likegitpython-developers#1988 is made to test/supportPython 3.12 on Cygwin. At least for now, though, this seemsworthwhile for fixing the Cygwin 3.9 environment, making it moresimilar to working local Cygwin environments and letting theworkflow be more usable as guidance to how to set up a local Cygwinenvironment for GitPython development, and letting the installationtest pass automatically.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cygwin job is broken on "Set up virtualenv" step
2 participants
@EliahKagan@Byron

[8]ページ先頭

©2009-2025 Movatter.jp