Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork960
Fuzzing: Fix Broken Fuzz Test for Git Submodule Handling#1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Byron merged 1 commit intogitpython-developers:mainfromDaveLak:fuzzing/fuzz-targets/git-broken-fuzz-submodule-testJan 11, 2025
Merged
Fuzzing: Fix Broken Fuzz Test for Git Submodule Handling#1997
Byron merged 1 commit intogitpython-developers:mainfromDaveLak:fuzzing/fuzz-targets/git-broken-fuzz-submodule-testJan 11, 2025
+42 −17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Ensured submodule names, paths, and commit messages are sanitized toavoid invalid states that are expected to cause exceptions and shouldnot halt the fuzzer.In particular, the changes here:- Sanitized inputs for submodule names, paths, and commit messages.- Added validation for submodule SHA and path integrity.
Byron approved these changesJan 11, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for your continued support with this, it's much appreciated!
583c011 intogitpython-developers:main 24 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This worked. Issue now resolved on the OSS-Fuzz tracker:https://issues.oss-fuzz.com/379326001 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there 👋
As you may or may not have seen, the
fuzz_submodule.pyharness has been failing for some time now and I believe it is responisble for the "fuzzing build: failing" status on OSS-Fuzz.I looked into it and it appears to be an issue with the test implementation, not GitPython.
The changes here should fix the issue causing the failure!
Please see the commit message for additional details.