Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Don't support building documentation on Python 3.7#1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This removes the specially cased alternative lower versions of`sphinx` and its dependencies that, sincegitpython-developers#1954, were only forPython 3.7. As discussed in comments there, this simplifies thedocumentation dependencies and avoids a situation where the versionof Python used to build the documentation has a noticeable effecton the generated result.This also conditions running the "Documentation" step in the mainCI test workflow (`pythonpackage.yml`) on the Python version notbeing 3.7 (otherwise the job would always fail).The only change this makes to the support status of GitPython onPython 3.7 is to no longer support building documentation on 3.7.GitPython can still be installed and used on 3.7 (though usuallythis would not be a good idea, outside of testing, since Python 3.7itself has not been supported by the Python Software Foundation forquite some time). In addition, the documentation, which can bebuilt on any version >= 3.8 (including 3.13 starting ingitpython-developers#1954) isno less relevant to usage on Python 3.7 than it was before.
Byron approved these changesAug 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fantastic, so much simpler, thanks a lot!
cfadd9e
intogitpython-developers:main 22 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This removes the specially cased alternative lower versions of
sphinx
and its dependencies that, since#1954, were only for Python 3.7. As discussed in comments there, this simplifies the documentation dependencies and avoids a situation where the version of Python used to build the documentation has a noticeable effect on the generated result.This also conditions running the "Documentation" step in the main CI test workflow (
pythonpackage.yml
) on the Python version not being 3.7 (otherwise the job would always fail).The only change this makes to the support status of GitPython on Python 3.7 is to no longer support building documentation on 3.7. GitPython can still be installed and used on 3.7 (though usually this would not be a good idea, outside of testing, since Python 3.7 itself has not been supported by the Python Software Foundation for quite some time). In addition, the documentation, which can be built on any version >= 3.8 (including 3.13 starting in#1954) is no less relevant to usage on Python 3.7 than it was before.
This should not be able to have any effect on other Python versions, including Python 3.12, which GitPython currently uses for its Read the Docs builds. But just in case, and to guard against inadvertent syntax errors,here's the successful PR preview build.