Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Don't support building documentation on Python 3.7#1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 1 commit intogitpython-developers:mainfromEliahKagan:no37doc
Aug 18, 2024

Conversation

EliahKagan
Copy link
Member

@EliahKaganEliahKagan commentedAug 18, 2024
edited
Loading

This removes the specially cased alternative lower versions ofsphinx and its dependencies that, since#1954, were only for Python 3.7. As discussed in comments there, this simplifies the documentation dependencies and avoids a situation where the version of Python used to build the documentation has a noticeable effect on the generated result.

This also conditions running the "Documentation" step in the main CI test workflow (pythonpackage.yml) on the Python version not being 3.7 (otherwise the job would always fail).

The only change this makes to the support status of GitPython on Python 3.7 is to no longer support building documentation on 3.7. GitPython can still be installed and used on 3.7 (though usually this would not be a good idea, outside of testing, since Python 3.7 itself has not been supported by the Python Software Foundation for quite some time). In addition, the documentation, which can be built on any version >= 3.8 (including 3.13 starting in#1954) is no less relevant to usage on Python 3.7 than it was before.

This should not be able to have any effect on other Python versions, including Python 3.12, which GitPython currently uses for its Read the Docs builds. But just in case, and to guard against inadvertent syntax errors,here's the successful PR preview build.

This removes the specially cased alternative lower versions of`sphinx` and its dependencies that, sincegitpython-developers#1954, were only forPython 3.7. As discussed in comments there, this simplifies thedocumentation dependencies and avoids a situation where the versionof Python used to build the documentation has a noticeable effecton the generated result.This also conditions running the "Documentation" step in the mainCI test workflow (`pythonpackage.yml`) on the Python version notbeing 3.7 (otherwise the job would always fail).The only change this makes to the support status of GitPython onPython 3.7 is to no longer support building documentation on 3.7.GitPython can still be installed and used on 3.7 (though usuallythis would not be a good idea, outside of testing, since Python 3.7itself has not been supported by the Python Software Foundation forquite some time). In addition, the documentation, which can bebuilt on any version >= 3.8 (including 3.13 starting ingitpython-developers#1954) isno less relevant to usage on Python 3.7 than it was before.
@EliahKaganEliahKagan marked this pull request as ready for reviewAugust 18, 2024 18:14
@EliahKaganEliahKagan mentioned this pull requestAug 18, 2024
Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fantastic, so much simpler, thanks a lot!

EliahKagan reacted with thumbs up emoji
@ByronByron merged commitcfadd9e intogitpython-developers:mainAug 18, 2024
22 checks passed
@EliahKaganEliahKagan deleted the no37doc branchAugust 18, 2024 19:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ByronByronByron approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@EliahKagan@Byron

[8]ページ先頭

©2009-2025 Movatter.jp