Fuzzing: Gracefully Handle Uninteresting Error to Fix OSS-Fuzz Issue#1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Byron merged 1 commit intogitpython-developers:mainfromDaveLak:fuzzing/issues/71095

Aug 13, 2024

Merged

Fuzzing: Gracefully Handle Uninteresting Error to Fix OSS-Fuzz Issue#1952

Byron merged 1 commit intogitpython-developers:mainfromDaveLak:fuzzing/issues/71095

Aug 13, 2024

Conversation

Copy link

Contributor

DaveLak commentedAug 13, 2024

Fixeshttps://bugs.chromium.org/p/oss-fuzz/issues/detail?id=71095

Fuzzing data can generate filenames that trigger:

OSError: [Errno 36] File name too long

The changes here add handling for these exceptions because they di not indicate a bug and should not crash the fuzzer.

Fuzzing: Gracefully Handle Uninteresting Error to Fix OSS-Fuzz Issue …

7126ce1

…71095Fuzzing data can generate filenames that trigger:> OSError: [Errno 36] File name too longThe changes here add handling for these exceptions because they di notindicate a bug and should not crash the fuzzer.a

Byron approved these changes

Aug 13, 2024

View reviewed changes

Copy link

Member

Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, thanks for making this work!

It's interesting that the Rust version of this doesn't have this entire class of issues - the only thing that matters are panics, errors like these are considered valid behaviour.

Of course, in Python there is no such differentiation, hence the extra-trouble of having to allow all kinds of exceptions that the fuzzer can legitimately run into.