Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork966
Fuzzing: Gracefully Handle Uninteresting Error to Fix OSS-Fuzz Issue#1952
Merged
Byron merged 1 commit intogitpython-developers:mainfromAug 13, 2024
Merged
Conversation
…71095Fuzzing data can generate filenames that trigger:> OSError: [Errno 36] File name too longThe changes here add handling for these exceptions because they di notindicate a bug and should not crash the fuzzer.a
Byron approved these changesAug 13, 2024
Member
Byron left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me, thanks for making this work!
It's interesting that the Rust version of this doesn't have this entire class of issues - the only thing that matters are panics, errors like these are considered valid behaviour.
Of course, in Python there is no such differentiation, hence the extra-trouble of having to allow all kinds of exceptions that the fuzzer can legitimately run into.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixeshttps://bugs.chromium.org/p/oss-fuzz/issues/detail?id=71095
Fuzzing data can generate filenames that trigger:
The changes here add handling for these exceptions because they di not indicate a bug and should not crash the fuzzer.