Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove the non-ARM macOS CI jobs#1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 2 commits intogitpython-developers:mainfromEliahKagan:ci-arm-instead
Jul 24, 2024

Conversation

EliahKagan
Copy link
Member

@EliahKaganEliahKagan commentedJul 24, 2024
edited
Loading

This keeps only themacos-14 jobs, which run on Apple Silicon M1, and removes themacos-13 jobs, which ran on x86-64. This relates to the commented discussion in#1944. There would also be the option of keeping some of them, but removing all of them decreases the workload the most while also being the simplest.

It also uses the labelmacos-latest instead, which is currently equivalent tomacos-14.

  • Some information about the situation withmacos-latest and the benefit of using it is presented in the second commit message.
  • That these jobs really are running on macOS 14, and more importantly that they are really running on ARM64, can be verified by examining the output of "Set up job" step.Here's an example.

Other operating systems' jobs continue to run on x86-64 machines (and none on ARM, yet). Only macOS jobs are removed.

This change leaves Python 3.7 without any macOS test job. That is probably okay, since it has been end-of-life for some time, and it remains tested on Ubuntu and Windows.

This keeps only the macos-14 jobs, which run on Apple Silicon M1,and removes the macos-13 jobs, which ran on x86-64.Other operating systems jobs continue to run on x86-64 machines(and none on ARM, yet). Only the macOS jobs are removed.This change leaves Python 3.7 without any macOS test job. That isprobably okay, since it has been end-of-life for some time, andit remains tested on Ubuntu and Windows.
Currently they are the same. The macos-latest label will move tolater versions automatically in the future, like the ubuntu-latestand windows-latest labels that we are already using.In this repo, the macos-14 label had been used originally becauseit was added before the migration of macos-latest to be macos-14was completed. Seegithub/roadmap#926. Itwas kept for clarity of constrast with the macos-13 jobs that werealso in use, some for the same Python versions.Now that the macos-13 jobs have been removed inc2bbaf4, themacos-latest label can be used here without confusion.
@EliahKaganEliahKagan marked this pull request as ready for reviewJuly 24, 2024 08:56
Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot, much appreciated!

EliahKagan reacted with thumbs up emoji
@ByronByron merged commit855befa intogitpython-developers:mainJul 24, 2024
22 checks passed
@EliahKaganEliahKagan deleted the ci-arm-instead branchJuly 24, 2024 16:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ByronByronByron approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@EliahKagan@Byron

[8]ページ先頭

©2009-2025 Movatter.jp